Difference between revisions of "Newbie Guide for Windows People Working on Minor Bugs"

From Dreamwidth Notes
Jump to: navigation, search
m
m
Line 19: Line 19:
 
== Create an account on GitHub ==
 
== Create an account on GitHub ==
  
* Go to [http://www.github.com/ GitHub], click on 'sign up and pricing' and create a free account. I suggest you pick a username people are familiar with and the same username you'll have on your Bugzilla account.
+
Go to [http://www.github.com/ GitHub], click on 'sign up and pricing' and create a free account. I suggest you pick a username people are familiar with and the same username you'll have on your Bugzilla account.
  
  
 
== Get a Dreamhack ==
 
== Get a Dreamhack ==
  
* Apply for a Dreamhack by [http://hack.dreamwidth.net/apply.shtml filling this form]. The two important fields are 'your desired username' and 'your email address'. Your username is used to manage your Dreamhack and to create the URL where your Dreamhack will be located at so you can pick anything. Your email address is used to send you a welcome e-mail which contains important information as well as various alerts. You can pick any of your existing email addresses or choose to create an email account entirely devoted to your development work.
+
Apply for a Dreamhack by [http://hack.dreamwidth.net/apply.shtml filling this form]. The two important fields are 'your desired username' and 'your email address'. Your username is used to manage your Dreamhack and to create the URL where your Dreamhack will be located at so you can pick anything. Your email address is used to send you a welcome e-mail which contains important information as well as various alerts. You can pick any of your existing email addresses or choose to create an email account entirely devoted to your development work.
  
* Once you're done, you should get an e-mail with your login username and a password. Don't lose it.
+
Once you're done, you should get an e-mail with your login username and a password. Don't lose it.
  
  
Line 61: Line 61:
 
== Create a Bugzilla account ==
 
== Create a Bugzilla account ==
  
* Simply [http://bugs.dwscoalition.org/createaccount.cgi click here].
+
Simply [http://bugs.dwscoalition.org/createaccount.cgi click here].
  
* As <dwuser>mark</dwuser> explained [http://dw-dev.dreamwidth.org/17146.html here], go to [http://bugs.dwscoalition.org/userprefs.cgi?tab=account Name and Password] and enter your name following this format: <code>Name [:username]</code>. 'Name' can be your real name, a nickname, your username again, etc. You don't have to give your real name if you don't want to.
+
: N.B. As <dwuser>mark</dwuser> explained [http://dw-dev.dreamwidth.org/17146.html here], go to [http://bugs.dwscoalition.org/userprefs.cgi?tab=account Name and Password] and enter your name following this format: <code>Name [:username]</code>. 'Name' can be your real name, a nickname, your username again, etc. You don't have to give your real name if you don't want to.
  
  
Line 100: Line 100:
 
=== Give special abilities to your system account ===
 
=== Give special abilities to your system account ===
  
* Log in to your Dreamhack (http://www.yourusername.hack.dreamwidth.net/) using system and your password.
+
* Log in to your Dreamhack (http://www.USERNAME.hack.dreamwidth.net/) using system and your password.
  
* Go to [http://www.yourusername.hack.dreamwidth.net/admin/priv/ http://www.yourusername.hack.dreamwidth.net/admin/priv/]. Click on 'payments' type 'system' in the User field then click on 'Make Changes'. The system account now has the ability (called 'privilege' or 'priv') to give paid time to any account.
+
* Go to [http://www.USERNAME.hack.dreamwidth.net/admin/priv/ http://www.USERNAME.hack.dreamwidth.net/admin/priv/]. Click on 'payments' type 'system' in the User field then click on 'Make Changes'. The system account now has the ability (called 'privilege' or 'priv') to give paid time to any account.
  
* Go to [http://www.yourusername.hack.dreamwidth.net/admin/pay http://www.yourusername.hack.dreamwidth.net/admin/pay]. Type 'system' in the Edit user field and click on Go. Make your account a seed one.
+
* Go to [http://www.USERNAME.hack.dreamwidth.net/admin/pay http://www.USERNAME.hack.dreamwidth.net/admin/pay]. Type 'system' in the Edit user field and click on Go. Make your account a seed one.
  
  
Line 127: Line 127:
 
== Update your code ==
 
== Update your code ==
  
* Code is committed by developers all the time. You must always update your repositories before you do anything else using the <code>pull</code> command:
+
Code is committed by developers all the time. You must always update your repositories before you do anything else.
 +
 
 +
*  Use the <code>pull</code> command to fetch updates to each of the base branch:
  
 
<syntaxhighlight lang="bash">cd $LJHOME
 
<syntaxhighlight lang="bash">cd $LJHOME
Line 133: Line 135:
 
git pull dreamwidth master:master</syntaxhighlight>
 
git pull dreamwidth master:master</syntaxhighlight>
  
* Now use the <code>push</code> command to forward the changes on your GitHub fork:
+
* Then use the <code>push</code> command to forward the changes on your GitHub fork:
  
 
<syntaxhighlight lang="bash">git push origin develop
 
<syntaxhighlight lang="bash">git push origin develop
 
git push origin master</syntaxhighlight>
 
git push origin master</syntaxhighlight>
  
: N.B. This will ask you your password on GitHub. Again, the cursor won't move as you type it. This is normal.
+
: N.B. When you do this you be will asked for your password on GitHub. Again, the cursor won't move as you type it. This is normal.
  
* For the nonfree part of the code, the commands are exactly the same except the first one, as it's in a different folder:
+
* For the nonfree part of the code, the commands are exactly the same except the first one, as nonfree is in a different folder:
  
 
<syntaxhighlight lang="bash">cd $LJHOME/ext/dw-nonfree</syntaxhighlight>
 
<syntaxhighlight lang="bash">cd $LJHOME/ext/dw-nonfree</syntaxhighlight>
  
* You can also create a script to make this process simpler. See [[Dev_Maintenance#dwu_-_Updating_the_repos | this article]].
+
* You can also create a script to make this process simpler: see [[Dev_Maintenance#dwu_-_Updating_the_repos | this article]].
  
 
: N.B. To create a new file on WinSCP, right click into the correct folder (<code>/bin</code> here) then click on New/File.
 
: N.B. To create a new file on WinSCP, right click into the correct folder (<code>/bin</code> here) then click on New/File.
Line 157: Line 159:
 
$LJHOME/bin/upgrading/texttool.pl load</syntaxhighlight>
 
$LJHOME/bin/upgrading/texttool.pl load</syntaxhighlight>
  
* You can also create a script to make this process simpler. See [[Dev_Maintenance#dwdb_-_Updating_the_database | this article]].
+
* You can also create a script to make this process simpler: see [[Dev_Maintenance#dwdb_-_Updating_the_database | this article]].
  
  

Revision as of 11:33, 26 August 2012

Warning: This guide is currently being rewritten to reflect the new workflow. Some things may be unclear and some things may be missing. Please be patient.
Note: Feel free to correct, expand, do anything which could make this better and clearer. ^_^


What do you need and why?

Because you're on Windows, you have to use quite a number of tools to access and manage things so this part might seem a little daunting. The good news is that 1) you're used to being flexible and resourceful, right? 2) once you've got everything set up things will be much simpler and intuitive.

So what do you need?

  1. You need a Github account to be able to fetch the Dreamwith code, create your own copies of it, and upload your own changes. This is both where all the Dreamwidth code comes from and where your own code will end on but it's only a gateway: you can't do much on github.com itself.
  2. You need a Dreamhack to see what your changes will do on the site for real. Think of a Dreamhack as an online mirror of the Dreamwidth site which you get to play with and modify.
  3. You need PuTTY to connect GitHub to your Dreamhack, to connect your Dreamhack to GitHub, and access and manage everything. In short, PuTTY is your true center of command: you can't do anything without it.
  4. You need WinSCP to visualize your Dreamhack files and be able to open them in a text editor. It's pretty much like Explorer.
  5. You need a text editor to edit your files.
  6. You need a Bugzilla account to find bugs, files bugs and upload patches.

Create an account on GitHub

Go to GitHub, click on 'sign up and pricing' and create a free account. I suggest you pick a username people are familiar with and the same username you'll have on your Bugzilla account.


Get a Dreamhack

Apply for a Dreamhack by filling this form. The two important fields are 'your desired username' and 'your email address'. Your username is used to manage your Dreamhack and to create the URL where your Dreamhack will be located at so you can pick anything. Your email address is used to send you a welcome e-mail which contains important information as well as various alerts. You can pick any of your existing email addresses or choose to create an email account entirely devoted to your development work.

Once you're done, you should get an e-mail with your login username and a password. Don't lose it.


Install PuTTY

  • Download 'Windows installer for everything except PuTTYtel' .exe file at PuTTY and install it.
  • Run PuTTY. In the configuration window, enter "hack.dreamwidth.net" for the host name. Go to Connection/Data and enter the username/login given to you in the welcome e-mail. It should be something like dh-username.
  • Click on Open. If you get a pop-up message about a key, click Yes.
  • Enter the password given to you in the welcome e-mail when asked. Note that no characters are displayed and the cursor won't move. It's normal.
  • Change your password by typing:
passwd
  • Your default Dreamhack account is called system. Type this to set its password:
$LJHOME/bin/upgrading/make_system.pl


Install WinSCP

  • Install WinSCP. During the installation, you may be asked about the mode you prefer: Commander and Explorer. Commander works like an FTP client: a partitioned window with your computer files on one side and the Dreamhack files on the other. Explorer will only display your Dreamhack files and works like Windows's Explorer. I prefer this mode because I rarely need to access my computer files but choose what's easiest for you.
  • Use "hack.dreamwidth.net" for the host name. Enter your username and the password you typed when you did passwd on PuTTY. Click on Save then on Login.


Get a good text editor

While you can use Notepad, I recommend Notepad++ instead. It's free, simple and will make editing much easier.


Create a Bugzilla account

Simply click here.

N.B. As [info]mark explained here, go to Name and Password and enter your name following this format: Name [:username]. 'Name' can be your real name, a nickname, your username again, etc. You don't have to give your real name if you don't want to.


Set things up

On your GitHub account

You need to fork the Dreamwidth code onto your own account. Forking is like cloning and branching. It will copy the code and also label your copy as being a branch (a fork) of the original Dreamwidth code so that we know the two are connected.

Dreamwidth is divided into two parts: a open-source part called 'dw-free', and a private part called 'dw-nonfree'. The private part is composed of elements which are specific to dreamwidth.org and can't be used on other sites (the logo for example) and external elements Dreamwidth is allowed to use on its own site but not redistribute to other sites.


On your Dreamhack

Now you need to 'import' both of these onto your Dreamhack and link them to the original Dreamwidth repositories on GitHub so you can easily fetch updates.

To do so, follow all the steps from this point on until you start your server again (but skip the 'non-dreamhack users' section, of course).


Further configuration steps

These are not mandatory but will make your life easier.


Change some git settings

On PuTTY, I suggest going through all the steps mentioned in this section.

Warning: If anybody knows how to make your default Windows editor git's default editor, please say so. I've read multiple articles on this topic and nothing worked for me.


Give special abilities to your system account


Get rid of invite codes

  • In WinSCP, go to /dw/ext/local/etc/, and double-click on config.pl. Find $USE_ACCT_CODES = 1; and change 1 to 0. Save your file.
  • In PuTTY, type this to make the changes go live on your Dreamhack:
$LJHOME/bin/upgrading/update-db.pl -r -p --innodb
$LJHOME/bin/upgrading/update-db.pl -r --cluster=all --innodb
$LJHOME/bin/upgrading/texttool.pl load


Customize PuTTY and Notepad++


Make sure things are up-to-date

Update your code

Code is committed by developers all the time. You must always update your repositories before you do anything else.

  • Use the pull command to fetch updates to each of the base branch:
cd $LJHOME
git pull dreamwidth develop:develop
git pull dreamwidth master:master
  • Then use the push command to forward the changes on your GitHub fork:
git push origin develop
git push origin master
N.B. When you do this you be will asked for your password on GitHub. Again, the cursor won't move as you type it. This is normal.
  • For the nonfree part of the code, the commands are exactly the same except the first one, as nonfree is in a different folder:
cd $LJHOME/ext/dw-nonfree
  • You can also create a script to make this process simpler: see this article.
N.B. To create a new file on WinSCP, right click into the correct folder (/bin here) then click on New/File.


Update your database

  • We're already seen this once but here it is again:
$LJHOME/bin/upgrading/update-db.pl -r -p --innodb
$LJHOME/bin/upgrading/update-db.pl -r --cluster=all --innodb
$LJHOME/bin/upgrading/texttool.pl load
  • You can also create a script to make this process simpler: see this article.


Make changes to the code

Find or file a bug

Some of these bugs won't appear to require 'minor' effort to you. It's normal. Try to find small bugs among them: minor modifications to be done on one of the site pages (text to be modified; elements to be added, removed or moved; elements to be hidden from some categories of users, etc.).
  • To assign a bug to yourself, enter your Bugzilla e-mail address in Assign To and set the status to IN_PROGRESS.
To make this easier, you can also use one of [info]fu's Greasemonkey scripts: Dreamwidth Bug Grabber. Click on (grab!) next to Assign To and this will edit it and Status for you. Click on Save Changes of course.


Create a branch

  • You're going to create a new branch on your own copy of the Dreamwidth repository specifically dedicated to the bug you want to work on. Use the bug number and a short description in the name, like so:
git branch bug###/xxx
  • To switch to this branch, use the checkout command and the name of your branch:
git checkout bug###/xxx
  • You can also create and switch to a branch at the same time using:
git checkout -b bug###/xxx
  • And that's it. Now you can start coding!


Edit files

  • Use WinSCP to open the file(s) you need to edit.
  • Remember that the free part of the code is in ~/dw/* while the non-free part is in ~/dw/ext/dw-nonfree/*.
  • If you're working on site pages, you're working on .bml files. These are in ~dw/htdocs/ or one of the subsequent folders. You'll see that their names correspond to the URLs of site pages. These files may use .pm modules/widgets which are in ~dw/cgi-bin/DW/ or ~dw/LJ/.
  • For text strings which are not in ~dw/htdocs/xxx.bml.text files, see ~dw/bin/upgrading/en.dat.
  • For more specific searches, you can use the grep command: grep [option(s)] pattern [file(s)]

Interesting options:

-E: match using extended regular expressions -F: match using fixed strings -r: recursive -i: case insensitive -l: filename only -n: add relative line number

Examples:

grep -ri "find this text" * | more
This will search for "find this text" in all files and display it page by page.
grep -ril "find this text" * | more
This will search for "find this text" in all files but only display the relevant filenames and not any excerpts.
grep -rl print_entry $LJHOME/bin/upgrading/s2layers
This will search for files containing "print_entry" in the /s2layers folder, and only display the filenames as results.


Test your changes on your Dreamhack

  • In PuTTY, stop your Dreamhack:
stop-apache
  • Update your database by typing this or dwdb:
$LJHOME/bin/upgrading/update-db.pl -r -p --innodb
$LJHOME/bin/upgrading/update-db.pl -r --cluster=all --innodb
$LJHOME/bin/upgrading/texttool.pl load
  • Start your Dreamhack again:
start-apache
  • Go to your Dreamhack and test. Edit the files again in WinSCP if more changes are needed. Go through these steps again to test your new changes.


Request your changes to be pulled into Dreamwidth

Commit your changes

  • Use the commit command:
git commit
  • This will also open the nano editor so that you can type a commit message. Mention the bug number again and explain (quite briefly) what your changes do.
To exit the editor hit Ctrl+X then type Y to save your message.
  • You can also type the commit message as you commit your changes:
git commit 'm "commit message"

FIXME: issues with the number pad?


Push the changes to your GitHub fork

  • Use the push command and the branch name to push your changes to GitHub:
git push origin bug###/xxx


Request your changes to be pulled into the main code

  • On your GitHub page, click on the correct repository (dw-free or dw-nonfree), select the correct branch in the branch drop-down menu (this is below 'Clone in Windows') then click on Pull Request (it's at the top).


Note the pull request on Bugzilla

  • On your hard drive, create a simple text file indicating your patch is on GitHub (use a generic file).
  • Click on 'Add an Attachment' to attach your text file. Add a link to your pull request in the description, check and set Flags/Commit and Flags/Review to ?. Feel free to add questions or remarks. Click on Submit.
  • Wait for someone to review and commit your patch. You're done. :)


More: stashing your changes

FIXME


More: deleting a branch

FIXME


More: troubleshooting tips

Issues with text strings

  • As [info]denise explained here, you need to delete old text strings and create new ones when you edit .text files or en.dat instead of simply editing the text. If the change isn't critical - the string doesn't need to be renamed or the text change is minor - it's better to notify the site copy team so that text can be changed locally and the original file left alone.
  • If text you've modified doesn't appear on the site after a code push, append ?uselang=debug to the page URL to make sure it's using the right string. If it is and it still doesn't display after a while, comment on [info]dw_maintenance.

Starting over

  • Delete your copies of the Dreamwidth repositories:

FIXME


References