Difference between revisions of "Committing Guidelines"
From Dreamwidth Notes
(New page: (This page is just a brain dump for xb95 at present, it should be cleaned up, if someone feels up to the task...) == Basics of Committing == A few people have/are/will be given commit ac...) |
(No difference)
|
Revision as of 01:05, 19 January 2009
(This page is just a brain dump for xb95 at present, it should be cleaned up, if someone feels up to the task...)
Basics of Committing
A few people have/are/will be given commit access. Generally it's an invite-only sort of thing, if the existing pool of committers decide that you are familiar enough with the code and generally produce quality patches, you will be offered a commit access.
In general, the responsibilities of someone with commit are to make sure that:
- All code being committed has been reviewed, either by the committer or by a competent/known reviewer.
- All code being committed is either a bug fix for an existing feature, or if it's a new feature, said feature has been approved by the people that do feature approvals.
- The committer must be completely comfortable with the code in question, and comfortable that it will not eat data, destroy lives, or harm the site.
(pause brb)
